mIRC Home    About    Download    Register    News    Help

Print Thread
Joined: Jun 2023
Posts: 6
G
Gokturk Offline OP
Nutrimatic drinks dispenser
OP Offline
Nutrimatic drinks dispenser
G
Joined: Jun 2023
Posts: 6
I have encountered a bug while using mIRC v7.72 with the InspIRCd v4. The issue is related to the display of IP addresses on /whois response of the user. Currently, the IP address format appears as "IP is connecting from," Like: [09:43] 94.***.**.** is connecting from while it should display as "is connecting from ident@hostname ip address."

https://github.com/inspircd/inspircd/commit/de89682738cd843c76908ef8f8cdfefe517ac308

Joined: Jan 2004
Posts: 2,127
Hoopy frood
Offline
Hoopy frood
Joined: Jan 2004
Posts: 2,127
What's the name of a public network having this ircd behavior?

Joined: Dec 2002
Posts: 5,465
Hoopy frood
Offline
Hoopy frood
Joined: Dec 2002
Posts: 5,465
Thanks for your bug report. mIRC currently handles seven different formats for numeric 338. These formats have appeared in different ircds over the last 25 years.

Can you please type "/debug @debug" in your status window, perform the whois, and then post the results you see in the @debug window here for the numeric you think is causing the issue?

Update: Looking at the github comment, I can see why mIRC might not handle the third format being used by InspIRCd. I have changed the 338 code for the third format to be a little less strict. That said, it would still be useful to see your @debug results so I can see the numeric format.

Last edited by Khaled; 05/06/23 08:27 PM.
Joined: Jun 2023
Posts: 6
G
Gokturk Offline OP
Nutrimatic drinks dispenser
OP Offline
Nutrimatic drinks dispenser
G
Joined: Jun 2023
Posts: 6
Thanks for your quick reply.

-> testnet.inspircd.org WHOIS gokturk
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 311 Gokturk Gokturk Gokturk muyskne2.glasoperator.nl * :Gokturk Yilmaz - Gokturk@hybridirc.com
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 338 Gokturk Gokturk Gokturk@56-45-341-94.ftth.glasoperator.nl 94.341.45.56 :is connecting from
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 319 Gokturk Gokturk :#inspircd
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 312 Gokturk Gokturk sadie.testnet.inspircd.org :InspIRCd Test Network
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 379 Gokturk Gokturk :is using modes +iwx
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 344 Gokturk Gokturk NL :is connecting from Netherlands
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 671 Gokturk Gokturk :is using a secure connection
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 276 Gokturk Gokturk :has TLS client certificate fingerprint 85daa4f5de4d5e57d309fcd0e164ed42c5f7a347c633043a50d2d0aa659c7dea
<- @time=2023-06-06T10:21:41.743Z :testnet.inspircd.org 318 Gokturk Gokturk :End of /WHOIS list.

Joined: Jun 2023
Posts: 6
G
Gokturk Offline OP
Nutrimatic drinks dispenser
OP Offline
Nutrimatic drinks dispenser
G
Joined: Jun 2023
Posts: 6
Hello,

We are testing it on testnet.inspircd.org +6697 (New version of InspIRCd (v4))

Joined: Dec 2002
Posts: 5,465
Hoopy frood
Offline
Hoopy frood
Joined: Dec 2002
Posts: 5,465
Thanks for debug log. The change I made above has indeed resolved the issue.

That said, I notice that InspIRCd is using numeric 344 in the whois reply. This numeric is used as a MODE reply on some ircds, which is how mIRC has always parsed it. I have added a change so that numeric 344 is now treated as a whois reply if it contains a specific number of parameters/content. InspIRCd actually has two formats for numeric 344, one for InspIRCd 2.0 and one for InpsIRCd 3.0, so mIRC has to handle both.

These changes will be in the next beta.

Joined: Jun 2023
Posts: 6
G
Gokturk Offline OP
Nutrimatic drinks dispenser
OP Offline
Nutrimatic drinks dispenser
G
Joined: Jun 2023
Posts: 6
The issue is fixed now in the new version (7.73), thanks.


Link Copied to Clipboard