Forums Scripts & Popups need help making script cleaner

so my code is as clean as it can be?
and i tried without $shortfn still no go