mIRC Home    About    Download    Register    News    Help

Print Thread
line numbers in popups.ini #202465 23/07/08 01:29 AM
Joined: Feb 2006
Posts: 74
G
gbz Offline OP
Babel fish
OP Offline
Babel fish
G
Joined: Feb 2006
Posts: 74
Some of the line numbers in the default popups.ini aren't in order. maroon noticed this in this thread in mIRC Help for an older version, which made me check the default files for 6.33. They show the issue still persists.

Affected parts:

Code:
[bpopup]
...
n9=.Version:/ctcp $$?="Enter nickname:" version
n11=Set Away
...


Code:
[lpopup]
n2=Info:/uwho $1
n0=Whois:/whois $$1
n1=Query:/query $$1
n3=-
...
n6=.Unignore:/ignore -r $$1 1
n6=.Op:/mode # +ooo $$1 $2 $3
n7=.Deop:/mode # -ooo $$1 $2 $3
n6=.Voice:/mode # +vvv $$1 $2 $3
n7=.Devoice:/mode # -vvv $$1 $2 $3
...
n11=.Ban, Kick:/ban $$1 2 | /timer 1 3 /kick # $$1
n11=.Ban, Kick (why):/ban $$1 2 | /timer 1 3 /kick # $$1 $$?="Reason:"
...
n13=.Ping:/ctcp $$1 ping
n16=.Time:/ctcp $$1 time
n15=.Version:/ctcp $$1 version
n17=DCC
...


Re: line numbers in popups.ini [Re: gbz] #202471 23/07/08 04:34 AM
Joined: Aug 2004
Posts: 7,252
R
RusselB Offline
Hoopy frood
Offline
Hoopy frood
R
Joined: Aug 2004
Posts: 7,252
I can confirm that the order, and even the line duplication is in the default installation of mIRC 6.33
I just did an installation to a directory that had not previously existed, forcing the mIRC installer to go with the default settings.
I, however, found that the problem only affected the default order/setting for the lpopup section.

Quote:
[lpopup]
n2=Info:/uwho $1
n0=Whois:/whois $$1
n1=Query:/query $$1
n3=-
n4=Control
n5=.Ignore:/ignore $$1 1
n6=.Unignore:/ignore -r $$1 1
n6=.Op:/mode # +ooo $$1 $2 $3
n7=.Deop:/mode # -ooo $$1 $2 $3
n6=.Voice:/mode # +vvv $$1 $2 $3
n7=.Devoice:/mode # -vvv $$1 $2 $3
n8=.Kick:/kick # $$1
n9=.Kick (why):/kick # $$1 $$?="Reason:"
n10=.Ban:/ban $$1 2
n11=.Ban, Kick:/ban $$1 2 | /timer 1 3 /kick # $$1
n11=.Ban, Kick (why):/ban $$1 2 | /timer 1 3 /kick # $$1 $$?="Reason:"
n12=CTCP
n13=.Ping:/ctcp $$1 ping
n16=.Time:/ctcp $$1 time
n15=.Version:/ctcp $$1 version
n17=DCC
n18=.Send:/dcc send $$1
n19=.Chat:/dcc chat $$1
n20=-
n21=Slap!:/me slaps $$1 around a bit with a large trout


Lines n2 and n16 are out of order
lines n7 and n11 occur twice
line n6 occurs 3 times (one of which shows between the two n7 lines)


Re: line numbers in popups.ini [Re: gbz] #202472 23/07/08 05:06 AM
Joined: Oct 2003
Posts: 3,918
A
argv0 Offline
Hoopy frood
Offline
Hoopy frood
A
Joined: Oct 2003
Posts: 3,918
Does this actually have an effect on the functionality of mIRC? From what I've seen, the nN= numbers are just there for compatibility with the .ini format, it doesn't actually read it in the order given by the numbers themselves. For example, replacing all the values with "n1=" gave me the same popups file and everything worked just fine. It seems mIRC just reads lexically through the ini line by line regardless of the number. What exactly is the problem then?

edit: in fact, the nN isn't even required in itself, the following also works:

Code:
[qpopup]
q=Info:/uwho $$1
x=Query:/query $$1
z=Whois:/whois $$1
a=-
CEDG!=Ignore:/ignore $$1 1 | /closemsg $$1


edit2: Given the above information, I don't think the original bug report has anything to do with the order of numbers in the default popups file.. the OP never even confirmed that assumption (nor did anybody else).

Last edited by argv0; 23/07/08 05:17 AM.

- argv[0] on EFnet #mIRC
- "Life is a pointer to an integer without a cast"
Re: line numbers in popups.ini [Re: RusselB] #202548 24/07/08 07:46 PM
Joined: Feb 2006
Posts: 74
G
gbz Offline OP
Babel fish
OP Offline
Babel fish
G
Joined: Feb 2006
Posts: 74
Originally Posted By: RusselB
I, however, found that the problem only affected the default order/setting for the lpopup section.

Yeah, it's mostly lpopup. In bpopup, it's just that one line (#10) is missing. I overlooked that at first though, so my guess is that you did too.

Re: line numbers in popups.ini [Re: argv0] #202550 24/07/08 08:38 PM
Joined: Feb 2006
Posts: 74
G
gbz Offline OP
Babel fish
OP Offline
Babel fish
G
Joined: Feb 2006
Posts: 74
Originally Posted By: argv0
Does this actually have an effect on the functionality of mIRC?

I don't know if there are any scenarios where this could have an effect; I merely reported it as a bug because it certainly wasn't intended to be this way, and Khaled is probably more likely to see this here than in mIRC Help. I'm not going to judge on whether it's "worth fixing".

Re: line numbers in popups.ini [Re: gbz] #202562 25/07/08 07:09 AM
Joined: Aug 2004
Posts: 7,252
R
RusselB Offline
Hoopy frood
Offline
Hoopy frood
R
Joined: Aug 2004
Posts: 7,252
The fact that there are line numbers missing would not have an effect, and I did note that the line n10 is missing from bpopup, but since I know that the missing line number makes no difference (unless you're trying to refer to that specific line in a $readini command), I didn't realize it was properly part of your bug report.

However the multiple lines having the same N# reference, I think should be called a bug as the /writeini routine, to my knowledge, should've over-written the previous entries with the newer entry.

Therefore there should not be two or more lines with the same N# reference.

Re: line numbers in popups.ini [Re: gbz] #202757 29/07/08 03:15 PM
Joined: Dec 2002
Posts: 4,484
Khaled Offline
Hoopy frood
Offline
Hoopy frood
Joined: Dec 2002
Posts: 4,484
Thanks the line numbers have been corrected for the next version.