Forums Bug Reports $sfstate $sfile $msfile and reserved folder

-$sfile

$sfstate does not return "error" when accessing a reserved folder with $sfile

Select the Fonts folder, $sfile() returns $null as expected but $sfstate is not set to "error".
$sfstate is correctly set to "cancel" if we cancel the dialog, though.


-$msfile

You never really replied to me in here https://forums.mirc.com/ubbthreads.php/topics/262220 but it looks like you implemented my suggestion. But:



Select a file and then select the Fonts folder, this displays:

is $sfstate returning "error" correct behavior (indicating that something else than filenames were selected perhaps)?

For this example, it doesn't make sense that selecting the reserved folder after the filename causes $sfstate to return 'error' in a situation where $msfile(0) is positive and $msfile(1) is filled with a filename.

If any other folder had been click-on after the filename, the results for $msfile(0) and $msfile(1) would be filled identically, with $sfstate being $null instead of 'error'. I would think 'error' should be reserved for cases where you clicked on only a reserved folder or clicked on a filename in a way that doesn't fill it into $msfile(N)

Right, I see what has happened. It looks like the changes to set $sfstate for $msfile() affected $sfile(). This should be fixed for the next version.


Yes, the aim was to set $sfstate to "error" and to not return any files - this is how it will work in the next beta. Anything different to this behaviour is too complicated and will require changes to stable select file code used throughtout mIRC, so I will not be changing this.